Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rmodels.c, LoadImageFromCgltfImage() : fix base64 padding support #4112

Merged

Conversation

SuperUserNameMan
Copy link
Contributor

@SuperUserNameMan SuperUserNameMan commented Jun 27, 2024

This should fix the issue related to .gltf embeded textures in base64 format, by ignoring the optional = padding and calculating the data size in bytes correctly.

Before this patch, cgltf_load_buffer_base64() would fail, and the .gltfmodel would not load embedded textures.

Should not interfere with pending #4107

This should fix the issue related to `.gltf` embeded image in base64 format, by ignoring `=` padding and calculating the data size in bytes correctly.
i hope it's clear ennough
@raysan5 raysan5 merged commit a3ef381 into raysan5:master Jun 28, 2024
14 checks passed
@raysan5
Copy link
Owner

raysan5 commented Jun 28, 2024

@SuperUserNameMan Thanks for the review!

@SuperUserNameMan SuperUserNameMan deleted the debug-lgtf-base64-image-data-padding branch July 13, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants